Personal tools
You are here: Home Forum Install & build Re: ATTN Devs: patches for geom, netgenplugin

Re: ATTN Devs: patches for geom, netgenplugin

Up to Install & build

Re: ATTN Devs: patches for geom, netgenplugin

Posted by Kunda at November 30. 2017

Same theme as the my previous threads, these are misc. typo fixes for

* geom module

* netgenplugin

 

please confirm reciept, thanks!

 

Edit: attached patches are too large zipped so I added them to dropbox

https://www.dropbox.com/s/wbepy35menbloy7/OCC-geom-and-netgenplugin-patches.zip?dl=0

Attachments

Re: ATTN Devs: patches for geom, netgenplugin

Posted by Kunda at November 30. 2017

prematurely sent the previous email. I was able to attach zip to thread.. so no need to use dropbox

Re: ATTN Devs: patches for geom, netgenplugin

Posted by SMESH expert at November 30. 2017

Hello Kunda

Thank you for the patches. Unfortunately the GEOM patch is inapplicable to the current master state as it modifies the code as well.

Netgen patches committed.

Best regards

Edward

Re: ATTN Devs: patches for geom, netgenplugin

Posted by Kunda at November 30. 2017

Edward,

Thank you. Please let me know what part of the patch is causing an issue.

Re: ATTN Devs: patches for geom, netgenplugin

Posted by SMESH expert at November 30. 2017

Almost all changes in cxx and hxx file modify the code. E.g. the first changes in the patch file:

-Standard_Integer AdvancedEngine_DividedDiskDriver::Execute(LOGBOOK& log) const
+Standard_Integer AdvancedEngine_DividedDiskDriver::Execute(Handle(TFunction_Logbook)& log) const

-#if OCC_VERSION_MAJOR < 7
-  log.SetTouched(Label());
-#else
   log->SetTouched(Label());
-#endif

Best regards

Edward

Re: ATTN Devs: patches for geom, netgenplugin

Posted by Kunda at December 02. 2017

Edward,

Apologies, I accidentally made a patch against master instead of the V8_4_BR branch.

Here is the patch, intended to be applied against V8_4_BR branch, is that OK ?

Attachments

Re: ATTN Devs: patches for geom, netgenplugin

Posted by SMESH expert at December 04. 2017

GEOM patch committed to master

Best regards

Edward

Re: ATTN Devs: patches for geom, netgenplugin

Posted by Kunda at December 04. 2017

Thanks for merging patches ;)

Powered by Ploneboard
Document Actions